Skip to content

ACNA-3510: validate app config by default #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hannah-taub-1 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ACNA-3510: validate app config by default #897

hannah-taub-1 wants to merge 4 commits into from

Conversation

@hannah-taub-1
Copy link

@hannah-taub-1 hannah-taub-1 commented Jan 13, 2026

Description

  1. Set validateAppConfig to true by default in the BaseCommand method getFullConfig.
  2. Add input flag to set validateAppConfig manually.
  3. Ensure that flags are passed into this method no matter the type of command.

Related Issue

https://jira.corp.adobe.com/browse/ACNA-3510

Motivation and Context

How Has This Been Tested?

  1. Added debug logs to check for the value of validateAppConfig.
  2. Ran multiple commands in a test repo (deploy, logs) to make sure the value was propagating correctly.
  3. Updated unit tests to check for true and false validateAppConfig values.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MichaelGoberling
Copy link
Contributor

MichaelGoberling commented Jan 13, 2026

This is an awesome start. Great job! Couple things here:

  • Imo in the description we shouldn't qualify the config-validation flag as only happening before deploying since it happens before other actions now too
  • There are still some commands that need to inherit the BaseCommand flags, so far I can see: test, set/get log forwarding, and get log-forwarding errors. I would just double check every command that's using getFullConfig() has the flags defined and are spread from BaseCommand
  • Maybe a Q for @shazron - Do we want to use config-validation in pack, or keep it hard-coded to always verify?

shazron
shazron approved these changes Jan 14, 2026
View reviewed changes
src/commands/app/test.js
unit = true
}

const buildConfigs = await this.getAppExtConfigs({ extension })
Copy link
Member

@shazron shazron Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a comment on your code but previous code: not sure how the previous code worked since it shouldn't. The unit tests didn't catch this https://github.com/adobe/aio-cli-plugin-app/blob/master/test/commands/app/test.test.js

Copy link
Author

@hannah-taub-1 hannah-taub-1 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wild! What was the issue?

Copy link
Member

@shazron shazron Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a red herring.
At first glance aio app test should not have worked, basically - the first param should be flags (object) - you pass in all the flags, but { extension } (object) is passed. But it's just the call is passing in only the extension flag itself.

MichaelGoberling
MichaelGoberling approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shazron
Copy link
Member

shazron commented Jan 16, 2026

  • Maybe a Q for @shazron - Do we want to use config-validation in pack, or keep it hard-coded to always verify?

Always verify in pack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shazron shazron shazron approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hannah-taub-1 @MichaelGoberling @shazron